Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support allowH2 on urllib@4 #5357

Merged
merged 5 commits into from
Sep 16, 2024
Merged

feat: support allowH2 on urllib@4 #5357

merged 5 commits into from
Sep 16, 2024

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Sep 15, 2024

@fengmk2 fengmk2 mentioned this pull request Sep 15, 2024
Open
2 tasks
@socket-security Socket Security
Copy link

socket-security bot commented Sep 15, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] environment, network 0 12.1 kB fengmk2

🚮 Removed packages: npm/[email protected]

View full report↗︎

@socket-security Socket Security
Copy link

socket-security bot commented Sep 15, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Sep 15, 2024 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov Codecov
Copy link

codecov bot commented Sep 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.74%. Comparing base (550a4f1) to head (d353b30).
Report is 1 commits behind head on 3.x.

Additional details and impacted files 
@@            Coverage Diff             @@
##              3.x    #5357      +/-   ##
==========================================
- Coverage   99.75%   99.74%   -0.01%     
==========================================
  Files          36       35       -1     
  Lines        3675     3573     -102     
  Branches      526      527       +1     
==========================================
- Hits         3666     3564     -102     
  Misses          9        9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fengmk2
Copy link
Member Author

fengmk2 commented Sep 15, 2024

image

@fengmk2
Copy link
Member Author

fengmk2 commented Sep 15, 2024

@coderabbitai 提交一个 issue 跟进此功能后续会合并到 master 分支

fengmk2
fengmk2 commented Sep 15, 2024
View reviewed changes
lib/egg.js Outdated Show resolved Hide resolved
@fengmk2 fengmk2 marked this pull request as draft September 15, 2024 10:31
@coderabbitai coderabbitai bot mentioned this pull request Sep 15, 2024
Open
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Sep 15, 2024

Tip

For best results, initiate chat on the files or code changes.

@fengmk2，问题已成功创建，链接是：#5358

Analysis chain

@fengmk2 收到，我会提交一个 issue 来跟进该功能的合并。

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
gh issue create \
  --title "Track feature: support allowH2 on urllib@4" \
  --body "This issue is to track the feature discussed in PR https://github.com/eggjs/egg/pull/5357.

Requested by @fengmk2." \
  --assignee fengmk2

Length of output: 254

@fengmk2 fengmk2 marked this pull request as ready for review September 15, 2024 10:43
@fengmk2 fengmk2 marked this pull request as draft September 16, 2024 01:45
fengmk2
fengmk2 commented Sep 16, 2024
View reviewed changes
lib/egg.js Outdated Show resolved Hide resolved
@fengmk2 fengmk2 marked this pull request as ready for review September 16, 2024 01:58
killagu
killagu approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengmk2 fengmk2 merged commit 46d3fb2 into 3.x Sep 16, 2024
23 checks passed
@fengmk2 fengmk2 deleted the enableH2-use-undici-v6-for-3.x branch September 16, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killagu killagu killagu approved these changes

Assignees

@killagu killagu

Labels
core: httpclient
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fengmk2 @killagu